Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing app freeze when switching pages #3496

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Fixing app freeze when switching pages #3496

merged 3 commits into from
Jun 17, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Jun 6, 2024 •
edited
Loading

Prevent freezing by clearing focus from all elements when MMToolbar is clicked on short button delegate(Home, Projects or Explore buttons).
Fixes #3389

@VitorVieiraZ VitorVieiraZ added ready-for-testing Ready to be tested by testers crew - passed review by devs not-reproducible We could not reproduce the issue, needs input from reporter and removed not-reproducible We could not reproduce the issue, needs input from reporter labels Jun 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9401139627

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 59.98%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9401139627

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 59.98%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9401139627

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 59.98%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801
💛 - Coveralls

@VitorVieiraZ VitorVieiraZ removed the ready-for-testing Ready to be tested by testers crew - passed review by devs label Jun 6, 2024
@VitorVieiraZ VitorVieiraZ changed the title WIP - Fixing app freezing when switching pages Fixing app freezing when switching pages Jun 6, 2024
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera June 6, 2024 13:57
@VitorVieiraZ VitorVieiraZ changed the title Fixing app freezing when switching pages Fixing app freeze when switching pages Jun 6, 2024
@github-actions GitHub Actions

This comment was marked as spam.

Sign in to view
2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9402120717

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 59.925%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.58%
Totals Coverage Status
Change from base Build 9382599374: -0.04%
Covered Lines: 7671
Relevant Lines: 12801
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9402120717

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 59.925%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.58%
Totals Coverage Status
Change from base Build 9382599374: -0.04%
Covered Lines: 7671
Relevant Lines: 12801
💛 - Coveralls

@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera June 10, 2024 14:22
tomasMizera
tomasMizera approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing the fix. @uclaros can we please ask you to test this build out? We can not reproduce it on our devices

@MerginMaps MerginMaps deleted a comment from github-actions bot Jun 10, 2024
@MerginMaps MerginMaps deleted a comment from github-actions bot Jun 10, 2024
@MerginMaps MerginMaps deleted a comment from github-actions bot Jun 10, 2024
@uclaros
Copy link
Contributor

uclaros commented Jun 10, 2024

I tested the artifact and the issue is mostly fixed!
However, when local projects model is empty, which was the case when i first installed the apk, the freeze is still there when trying to switch between any of the three pages.

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9486857460

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.909%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7669
Relevant Lines: 12801
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9487161223

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 59.98%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9487161223

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 59.98%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9487161223

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 59.98%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801
💛 - Coveralls

@tomasMizera
Copy link
Collaborator

Please mark this one WIP: xyz as this is still a draft PR :)

@VitorVieiraZ VitorVieiraZ changed the title Fixing app freeze when switching pages WIP - Fixing app freeze when switching pages Jun 13, 2024
@VitorVieiraZ VitorVieiraZ force-pushed the fix/appFreezingSwitchingPage branch from 1a07b93 to 908e82c Compare June 13, 2024 21:33
@VitorVieiraZ VitorVieiraZ changed the title WIP - Fixing app freeze when switching pages Fixing app freeze when switching pages Jun 13, 2024
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9507086492

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 59.992%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9499997026: 0.08%
Covered Lines: 7679
Relevant Lines: 12800
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9507086492

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 59.992%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9499997026: 0.08%
Covered Lines: 7679
Relevant Lines: 12800
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9507086492

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 59.992%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9499997026: 0.08%
Covered Lines: 7679
Relevant Lines: 12800
💛 - Coveralls

@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera June 13, 2024 22:14
tomasMizera
tomasMizera approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable

@uclaros
Copy link
Contributor

uclaros commented Jun 14, 2024

Works for me too!

@tomasMizera
Copy link
Collaborator

@VitorVieiraZ Can you please check why the gallery app is failing to build on the CI please?

@tomasMizera tomasMizera merged commit c995faa into master Jun 17, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix/appFreezingSwitchingPage branch June 17, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App freezes when switching betwee Home and Projects page while searching projects
5 participants
@VitorVieiraZ @uclaros @coveralls @tomasMizera @inputapp-bot