-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling a missing photo in photo field #3410
Conversation
Thanks Vitor for fixing this issue. Don't we need to show a message about the old photo not being available and if the user does not take any action (i.e. take a new photo or attach one from gallery) we still keep the link between the missing photo and feature. The user might want to fix the issue by restoring the photo from elsewhere (e.g. uploading it through the plugin). |
Pull Request Test Coverage Report for Build 8969989879Details
💛 - Coveralls |
You’re welcome! The message is now applied when the photo is missing. The user has two options: either click on the trash button to remove the missing file from the feature, or fix it, and then the file will be displayed normally when they open the app again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning message looks good, but I need to dive deeper into the code to check the internal.absolutrImagePath
assignement
Partially fixes #3405