Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale injected branch protection info #5131

Closed
ggreif opened this issue Dec 5, 2024 · 1 comment
Closed

Stale injected branch protection info #5131

ggreif opened this issue Dec 5, 2024 · 1 comment

Comments

@ggreif
Copy link

ggreif commented Dec 5, 2024

Expected Behavior

When changing the GH brach protection rules to run macos-13 instead of the (unsupported) macos-12, mergify should update the injected branch protection rules.

Actual Behavior

I merged dfinity/motoko#4791 a few days back. Our admins changed the branch protections, now they don't contain macos-12 references any more.

Instead the injected rules (even for fresh PRs!) won't get updated, and stay stale. This renders the PRs non-merged until I manually intervene. See below:

screenshot_2024-12-05_at_13 48 50_720

Here is a live example: dfinity/motoko#4802

Steps to Reproduce the Problem

  1. Change one target OS to a bumped one in the build matrix (macos-12 -> macos-13) and update branch protections for the main (default) branch.
  2. Re-run checks
  3. Check Mergify summary: Injected rules are stale

Running @mergifyio refresh won't help.

Specifications

@ggreif ggreif changed the title suspected stale branch protection info Suspected stale branch protection info Dec 5, 2024
@ggreif ggreif changed the title Suspected stale branch protection info Suspected stale injected branch protection info Dec 5, 2024
@ggreif ggreif changed the title Suspected stale injected branch protection info Stale injected branch protection info Dec 5, 2024
@ggreif
Copy link
Author

ggreif commented Dec 18, 2024

Recent PRs have the correct check in that place. Closing as not reproducible.

@ggreif ggreif closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant