Skip to content

Commit

Permalink
Update readme to add timeFactor in conf
Browse files Browse the repository at this point in the history
WaveRider may take extra time for migration.  So we should normally
include time factor in the configuration file.

Also add more log for job status updates.
  • Loading branch information
jealous committed Feb 22, 2024
1 parent 1f31100 commit a1f75bb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ Available `float` config options:
* `vmPolicy`: the VM creation policy, specified as a map. Refer to the CLI usage
for the list of available options.
* `timeFactor`: a float number. default to 1. An extra factor to multiply based
on the time supplied by the task. Use it to resolve some task timeouts.
on the time supplied by the task. Add time factor to enlarge the default timeout of the task.
Because WaveRider may take extra time for job migration.
* `maxCpuFactor`: a float number. default to 4. The maximum CPU cores of the instance is set
to `maxCpuFactor` * `cpus` of the task.
* `maxMemoryFactor`: a float number. default to 4. The maximum memory of the instance is set
Expand Down Expand Up @@ -187,6 +188,7 @@ float {
address = 'op.center.address'
username = secrets.MMC_USERNAME
password = secrets.MMC_PASSWORD
timeFactor = 2
}
aws {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,15 @@ class FloatTaskHandler extends GridTaskHandler {
@Override
boolean checkIfCompleted() {
final FloatStatus st = floatExecutor.getJobStatus(task)
log.debug "got status ${st} for ${task.id} from float executor"
if (st.finished) {
status = COMPLETED
task.exitStatus = readExitStatus()
if (task.exitStatus == null) {
log.debug "can't get ${task.id} exit status from file system"
task.exitStatus = floatExecutor.getJobRC(task.id)
}
log.debug "set ${task.id} exit status to ${task.exitStatus}"
if (task.exitStatus == null) {
if (st.isError()) {
task.exitStatus = 1
Expand Down

0 comments on commit a1f75bb

Please sign in to comment.