feat: separate gif game sumary from minimap game summary #6602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6602 +/- ##
============================================
- Coverage 29.11% 29.09% -0.02%
+ Complexity 15295 15288 -7
============================================
Files 2837 2837
Lines 279718 279788 +70
Branches 49286 49299 +13
============================================
- Hits 81429 81417 -12
- Misses 192820 192918 +98
+ Partials 5469 5453 -16 ☔ View full report in Codecov by Sentry. |
Scoppio
force-pushed
the
feat/gif-options
branch
from
8d5b439 to
ab96212
Compare
HammerGS
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does?
A new option to enable or disable Gif Game Summary instead of having it hitching a hike on the minimap game summary. It will at the end of a game ask if the player wants to save the gif, if they dont want, them the gif is discarded.