Pintle turret and flags (MML #1741) #6601
Conversation
# Conflicts: # megamek/src/megamek/common/AmmoType.java
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6601 +/- ##
============================================
+ Coverage 29.04% 29.10% +0.05%
- Complexity 15180 15287 +107
============================================
Files 2837 2837
Lines 279411 279716 +305
Branches 49188 49279 +91
============================================
+ Hits 81145 81399 +254
+ Misses 192886 192861 -25
- Partials 5380 5456 +76 ☔ View full report in Codecov by Sentry. |
| @@ -24,6 +25,8 @@ | |||
|
|
|||
| public class AmmoType extends EquipmentType { | |||
|
|
|||
| private static final MMLogger LOGGER = MMLogger.create(AmmoType.class); | |||
There was a problem hiding this comment.
nitpick, the standard for logger in the project is logger lowecase.
There was a problem hiding this comment.
I noticed :)
The very widely adopted convention for constants (static final) however is ALL_CAPS. When Tex reworked the logger thing, he made another million changes and I didnt want to pick on that minuscule issue. But I'd really like to stay with our style guide and common styles unless there's good reason. Is there one?
There was a problem hiding this comment.
@rjhancock This kinda involves you :)
There was a problem hiding this comment.
This is a case of when I did the mass changes I was less worried about style guide and more worried about ensuring legal compliance.
Style guide says upper case (which is a best practice I ignored in this case due to a 2 week marathon run of more important issues), then it should be upper case.
See MegaMek/megameklab#1741 for more info (merge together)
This PR has a few unit updates as well as the described flag check changes. The description for pintle mounts now contain the weight if it has a fixed weight.