Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a parsing error and turns it into a singleton using enum #6600

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Feb 23, 2025

fix: fix a parsing error in random callsign generator and turns it into a singleton using enum

@Scoppio Scoppio added the Bug label Feb 23, 2025
@Scoppio Scoppio self-assigned this Feb 23, 2025
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.11%. Comparing base (1cc15a2) to head (75e7787).
Report is 75 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6600      +/-   ##
============================================
+ Coverage     29.04%   29.11%   +0.06%     
- Complexity    15180    15295     +115     
============================================
  Files          2837     2837              
  Lines        279411   279718     +307     
  Branches      49188    49286      +98     
============================================
+ Hits          81145    81429     +284     
+ Misses       192886   192820      -66     
- Partials       5380     5469      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I assume you remove the background loading cause it can't possibly save more than 10 ms on a modern PC.
Not as a suggestion for this PR but I had the thought of storing this as a yaml list (HAMMER: 2 // JULIAANA: 1) - reading this is very little code and it allows comments. Something for another day.

@HammerGS HammerGS merged commit c930747 into MegaMek:master Feb 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants