fix: actually I fixed everything that there was to fix on the minimap #6598
+69
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scoppio
commented
Feb 23, 2025
Comment on lines
+408
to
+414
| if (dialog.getMouseListeners().length == 0) { | ||
| dialog.addMouseListener(mouseListener); | ||
| dialog.addMouseMotionListener(mouseMotionListener); | ||
| dialog.addMouseWheelListener(mouseWheelListener); | ||
| dialog.addComponentListener(componentListener); | ||
| dialog.addComponentListener(componentListener); | ||
| } |
There was a problem hiding this comment.
avoid initializing the same dialog twice.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6598 +/- ##
=========================================
Coverage 29.10% 29.10%
- Complexity 15279 15289 +10
=========================================
Files 2837 2837
Lines 279674 279701 +27
Branches 49268 49269 +1
=========================================
+ Hits 81402 81417 +15
- Misses 192815 192831 +16
+ Partials 5457 5453 -4 ☔ View full report in Codecov by Sentry. |
psikomonkie
approved these changes
Feb 23, 2025
| g.setColor(Color.white); | ||
| g.drawString(sHeight, baseX + 5, baseY + 5); | ||
| g.drawString(sHeight, baseX - fontWidth, baseY + fontHeight); // + (fontHeight / 2)); |
There was a problem hiding this comment.
what are you talking about? there is no comment.... (amended and force pushed, thanks)
Scoppio
force-pushed
the
fix/minimap-level-numbers
branch
from
610b6b2 to
379ef11
Compare
SJuliez
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does?
Implements the same algorithm to draw the text on the coordinates that is used by the "drawUnit" when it wants to draw things like the sensor ping.
It also fixes a bunch of bugs related to the minimap not responding anymore. I moved a few functions around and things started to work, I won't complain.