Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactored princess chat commands to use a modular approach #6597

Merged

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Feb 22, 2025

What does this do?

Refactoring princess chat commands.

This simplifies a little bit how we create and add new princess chat commands, also makes it easier to parse commands, and adds support for localization.

All previous tests passes, I removed the Verbose tests and all verbose references I found in the code, as I will remove it in a future version.

Anything weid?

A "BIG" part of the change is just whitespace on the test, so its not exactly 2k lines changed here.

@Scoppio Scoppio self-assigned this Feb 22, 2025
@Scoppio Scoppio force-pushed the feat/princess-chat-commands-refactored branch from acd6d30 to 4d55510 Compare February 22, 2025 22:56
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.13%. Comparing base (84c5665) to head (5407b8b).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6597   +/-   ##
=========================================
  Coverage     29.13%   29.13%           
- Complexity    15348    15366   +18     
=========================================
  Files          2863     2863           
  Lines        279841   279868   +27     
  Branches      49290    49291    +1     
=========================================
+ Hits          81523    81553   +30     
+ Misses       192860   192855    -5     
- Partials       5458     5460    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Scoppio Scoppio force-pushed the feat/princess-chat-commands-refactored branch from 4d55510 to 84c5665 Compare February 23, 2025 02:09
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Co-Pilot and IDEA AI no issues detected

@HammerGS HammerGS merged commit cdc621e into MegaMek:master Feb 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants