Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improvements for Dataset Logger and its javadocs #6595

Merged

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Feb 22, 2025

Adds better javadocs, dataset logger now logs if the action is being taken by a bot, the parser is updated, places where the dataset logger logs data is changed, etc

@Scoppio Scoppio self-assigned this Feb 22, 2025
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.09%. Comparing base (1cc15a2) to head (d049701).
Report is 61 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6595      +/-   ##
============================================
+ Coverage     29.04%   29.09%   +0.05%     
- Complexity    15180    15267      +87     
============================================
  Files          2837     2837              
  Lines        279411   279730     +319     
  Branches      49188    49290     +102     
============================================
+ Hits          81145    81396     +251     
- Misses       192886   192889       +3     
- Partials       5380     5445      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Scoppio Scoppio force-pushed the fix/gameactions-log-overwriteappend-only branch from 40610c2 to d049701 Compare February 22, 2025 04:15
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Co-Pilot and IDEA AI no issues detected

@HammerGS HammerGS merged commit a9edb26 into MegaMek:master Feb 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants