feat: MMLogger using parametrized message and string formatter #6591
Conversation
…mplete compatibility, also, tests
Scoppio
force-pushed
the
feat/mmlogger
branch
from
156c528 to
cbcc39f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6591 +/- ##
============================================
+ Coverage 29.04% 29.10% +0.06%
- Complexity 15180 15291 +111
============================================
Files 2837 2837
Lines 279411 279729 +318
Branches 49188 49288 +100
============================================
+ Hits 81145 81421 +276
+ Misses 192886 192854 -32
- Partials 5380 5454 +74 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| verifyLog(Level.ERROR, "Error message: test"); | ||
| } | ||
|
|
||
| @Test |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| public void logMessage(String fqcn, Level level, org.apache.logging.log4j.Marker marker, String message, Throwable t) { | ||
| // Custom implementation for logging messages | ||
| } | ||
|
|
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| public boolean isEnabled(Level level, Marker marker, String message, Object p0, Object p1, Object p2, Object p3, Object p4, Object p5, Object p6, Object p7) { | ||
| return true; | ||
| } | ||
|
|
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| public boolean isEnabled(Level level, Marker marker, String message, Object p0, Object p1, Object p2, Object p3, Object p4, Object p5, Object p6, Object p7, Object p8, Object p9) { | ||
| return true; | ||
| } | ||
|
|
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| return; | ||
| } | ||
| automaticallyDismissDialog(); | ||
| testMMLogger.errorDialog("test", "Error message: {}", "test"); |
Check warning
Code scanning / CodeQL
Unused format argument Warning
Scoppio
force-pushed
the
feat/mmlogger
branch
from
a24cc7e to
a1dfbc7
Compare
What it does?
Adds parametrized messages and string formatter to the MMLogger, and makes obvious when the error command will open a dialog screen with the error.
This also shows how to properly use the different ways to setup parameters for the logs