Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -1 check to getColoredPlayerNameWithTeam #6567

Conversation

DM0000
Copy link
Collaborator

@DM0000 DM0000 commented Feb 17, 2025

Add check to set unassigned players to team "no team" in getColoredPlayerWithTeamName().

fixes #6509
tested fix with included save file and everything worked.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.03%. Comparing base (b8379d0) to head (830eb62).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #6567    +/-   ##
==========================================
  Coverage     29.03%   29.03%            
+ Complexity    15175    15143    -32     
==========================================
  Files          2836     2837     +1     
  Lines        279278   279094   -184     
  Branches      49235    49119   -116     
==========================================
- Hits          81087    81039    -48     
+ Misses       192816   192690   -126     
+ Partials       5375     5365    -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit d009123 into MegaMek:master Feb 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue][0.50.03] Non-playing connected client (observer/spectator) causes error in end game screen BV report
2 participants