Issue 6540: Towing from MM lobby #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psikomonkie
added
(RFE) Enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6549 +/- ##
=========================================
Coverage 29.03% 29.03%
- Complexity 15171 15204 +33
=========================================
Files 2837 2837
Lines 279466 279495 +29
Branches 49274 49290 +16
=========================================
+ Hits 81129 81153 +24
+ Misses 192957 192950 -7
- Partials 5380 5392 +12 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This is ready for review :) Thanks! |
SJuliez
reviewed
Feb 16, 2025
SJuliez
approved these changes
Feb 16, 2025
|
Sorry i broke up my own review by accidentally pressing Ctrl-Enter at some point |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for better towing support - this adds limited ability for a player to attach trailers to tractors in the MegaMek lobby. Does not support trailers-attached-to-trailers (I think this is a bug with trailers, not this) yet.
Princess will not fire indirect weapons from a trailer.
A step towards finishing #6540 and #1124