-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/gif your game #6527
feat/gif your game #6527
Conversation
…utStream still open
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6527 +/- ##
============================================
- Coverage 29.05% 29.03% -0.02%
+ Complexity 15160 15157 -3
============================================
Files 2835 2836 +1
Lines 279129 279279 +150
Branches 49214 49237 +23
============================================
- Hits 81104 81102 -2
- Misses 192652 192801 +149
- Partials 5373 5376 +3 ☔ View full report in Codecov by Sentry. |
d52a540
to
0aa6010
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty cool!
Will this support "normal" aka non-ACAR and PACAR games? |
Yes, those changes are directly into MegaMek vanilla. |
… have no visual won't show up on minimap
What it does
If you have the game minimap summary enabled, it will also make the gif of it.
once you start the game, every time a new image is generated it is added to the final gif.
New features
Destroyed units shown on minimap
It now shows the destroyed units on the minimap with its icon struck in the midle, they also have a heavy transparency applied to them.
ECM shows on the minimap
They differ from Sensors by having a dashed outline instead of a solid one.
Short name on the minimap
It's basically the display name without the player name, it can be turned on or off in the client settings.
It also works with non-stratops symbols
The following image is a debug image showing how the different symbols look like wiht the destroy mark
How it works?
It runs in its own thread, once every phase it receives a new buffered image, which is then enqueued in its own synchonized queue, and it build the GIF while the game runs. Very simple and easy, it is capable of handling exceptions and interruptions, sudden disconections or crashes, and will just "finish" the gif it started.
If you crash and then rejoin the game, the game object should have a new ID, so you would endup with a new gif as the continuation of the previous game.
Anything else?
Yes... do NOT use the
pink lemonade.theme
for the minimap if you plan on sharing the gifs on Discord or some other platforms... turns out the pink with green tones is too close to skin tone and the automod on Discord and some other NSFW moderation tools will pickup the gif as a potential NSFW gif and block it/delete it.