Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MASH equipment to use size values #6487

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Feb 2, 2025

The old style core and theater equipment cannot be used and the units used to load incorrectly.

@SJuliez SJuliez requested a review from HammerGS February 2, 2025 10:09
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.58%. Comparing base (e10aeb4) to head (af3103e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6487   +/-   ##
=========================================
  Coverage     28.57%   28.58%           
- Complexity    14406    14407    +1     
=========================================
  Files          2798     2798           
  Lines        275148   275148           
  Branches      48678    48678           
=========================================
+ Hits          78637    78639    +2     
+ Misses       191838   191837    -1     
+ Partials       4673     4672    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Scoppio Scoppio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sure I had fixed these almost a month ago.

@HammerGS HammerGS merged commit 785c47a into MegaMek:master Feb 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants