Princess Ice & Infantry On Ice Fix #5041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her movement planning. Currently, On a map with approximately 50/50 Ice/Land, she would jump and walk mechs onto the ice every turn, and lose many before she ever got to combat. With this change she jumped mechs into the ice Zero times in 10 games. And she will still walk on the ice when forced because she is landlocked. Otherwise she will take a land path around. Also fixes an unreported bug related to Infantry and Ice.
HoneySkull
reviewed
Jan 12, 2024
|
Played around with this today, and seems to improve things. Will merge unless anyone has code objections. |
HammerGS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives Princess some Cryophobia for Mechs and non-hover land vehicles in her movement planning. Currently, On a map with approximately 50/50 Ice/Land, she would jump and walk mechs onto the ice every turn, and lose many before she ever got to combat. With this change she jumped mechs into the ice Zero times in 10 games. And she will still walk on the ice when forced because she is landlocked. Otherwise she will take a land path around. There is simply no reason to be on Ice as a mech or non-hover ground vehicle except as an absolute last resort.
Also fixes a previously unreported bug related to Infantry and Ice where infantry would not willingly traverse Ice because they were grouped with the "I break the ice" crowd. Moved them to their own "I dont break the ice" group and they now will move across ice. Edited infantry test to reflect new expected value.
Sample savegame attached.
ICET1INFDeployed.sav.gz
Screen 1: Shows post-fix path over ice that Locusts would still take when they deployed landlocked. So it doesnt prevent use of ice entirely.
Screen 2: Vanilla pre-fix MM screen that shows that infantry that deployed landlocked will remain landlocked the entire game.
Screen 3: Shows post-fix infantry moving freely over ice from landlocked positions.