First pass at adding TAG-phase Torso Twist #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't pull this one yet, I just realized I started on the code consolidation work before making units that twisted in the TAG phase unable to twist again later that turn. I'll try to get that done tomorrow. While I think the |
|
Okay, this should be ready to go. |
NickAragua
requested changes
Jan 13, 2024
Sleet01
force-pushed
the
Implement_TAG_Torso_Twist_errata
branch
from
9486e79 to
4c04b4a
Compare
SJuliez
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Offboard / TAG phase to allow turret/torso twisting for units with TAG weapons in accordance with the errata ruling here:
https://bg.battletech.com/forums/index.php?topic=81851.0
, mainly by copying existing code in from
FiringDisplay.java.This also adds a separate message indicating that the Offboard/TAG phase is distinct from the Indirect Fire Targeting phase.
Testing:
Note: Given how much shared code there is between
TargetingPhaseDisplay.javaandFiringDisplay.java, I'd like to take a crack at creating an abstract parent class for these two displays. It should reduce total code by a couple thousand lines.