Fix #4648: Update AT Classes for MekMortar and IS BA Tube Arty #5027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that Mek Mortars (and, coincidentally, IS BA Tube Artillery) are filtered out of the MekHQ "Spend XP -> SPA" context menu because they have the AT Class "CLASS_NONE". Because MekHQ uses a different code path to validate weapon validity for SPAs, these weapons are filtered out in MekHQ but work fine in MegaMek.
This patch by itself only fixes the issue for IS BA Tube Artillery; the matching MekHQ PR here must also be applied to fix the issue for Mek Mortars as well.
We should probably look at:
but I have some other stuff to work on right now.
Tested with MegaMek and MekHQ; ran all tests on both packages.
Close #4648