Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1021 - Add CTRL-Backspace to remove all trailing illegal move steps. #5025

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

HoneySkull
Copy link
Collaborator

@HoneySkull HoneySkull commented Jan 8, 2024

This PR is to support #1021 to add some convenience for Evading when Aero units have extended move paths beyond their movement points. This is doesn't allow the Evade to work automatically like the issue suggests, however, it makes it easier to get back to the last legal move with a single keystroke instead of having to keep hitting the backspace key for each move step. This works with any unit type, not just aerospace.

image

CTRL-Backspace

image

@SJuliez
Copy link
Member

SJuliez commented Jan 9, 2024

It is my experience that we need to update the defaultKeyBinds.xml file when key binds are added or they won't work properly in a release (they do work in the IDE). Please add this.

@HoneySkull
Copy link
Collaborator Author

It is my experience that we need to update the defaultKeyBinds.xml file when key binds are added or they won't work properly in a release (they do work in the IDE). Please add this.

Good catch - will do.

@HoneySkull HoneySkull marked this pull request as draft January 9, 2024 15:40
@HoneySkull HoneySkull marked this pull request as ready for review January 9, 2024 18:06
@HoneySkull
Copy link
Collaborator Author

Tested in IDE and clean install directory. Ready for merge.

@SJuliez SJuliez merged commit eef21ce into MegaMek:master Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants