Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4520 princess only fires aero tag #5020

Merged
merged 10 commits into from
Jan 13, 2024
Merged

Fix 4520 princess only fires aero tag #5020

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8d71408
Initial pass at making Princess Aero TAG usage reasonable
Sleet01 Jan 6, 2024
313f3ba
Fix #1 for concurrency issue between threads
Sleet01 Jan 7, 2024
6a3ca1d
Account for bombs when calculating damage potential
Sleet01 Jan 7, 2024
25d478a
Logic error fix and cleanup
Sleet01 Jan 7, 2024
e97d105
Further cleanup, add caching of results per unit
Sleet01 Jan 7, 2024
5d54408
Fixes for GitHub inspections
Sleet01 Jan 7, 2024
3054e47
Add range cutoffs to incoming homing damage estimates
Sleet01 Jan 8, 2024
e4260eb
Comment cleanup and slight tweak to range filter for bombs
Sleet01 Jan 8, 2024
27c7e64
Move isIndirect to static method of WeaponType
Sleet01 Jan 9, 2024
efe7d67
Unify disparate "indirect" calculations
Sleet01 Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion megamek/src/megamek/client/bot/princess/FireControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ ToHitData guessToHitModifierHelperForAnyAttack(final Entity shooter,

final int smokeLevel = targetHex.terrainLevel(Terrains.SMOKE);
if (1 <= smokeLevel) {
// Smoke level doesn't necessary correspond to the to-hit modifier
// Smoke level doesn't necessarily correspond to the to-hit modifier
// even levels are light smoke, odd are heavy smoke
toHitData.addModifier((smokeLevel % 2) + 1, TH_SMOKE);
}
Expand Down
Loading