-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1031 - Show structure collapse warning when deploying and moving. #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set as draft - I have an edge case to solve for flying units over buildings. (Solved) |
neoancient
requested changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good overall. Just a couple quick and easy changes.
megamek/src/megamek/client/ui/swing/boardview/ConstructionWarningSprite.java
Outdated
Show resolved
Hide resolved
neoancient
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1031
Fixes #2595
Implements a feature to display a warning symbol on hexes with structures during the Deployment and Movement where the CF for the building is less than the weight of the selected entity.
In the deployment phase, hexes that are valid deployment hexes with buildings will display a warning symbol if CF of the structure is less than the weight of the selected entity combined with any existing entities on that hex.
In the movement phase, a warning symbol will be displayed on hexes with structures that could collapse within a generous movement radius. (max run/jump hexes in radial distance).
The structural warning symbols can be turned on an off in the view menu:
