Fixed Code QL error - unused parameters.

MegaMek · Dec 26, 2023 · 356b0c7 · 356b0c7
1 parent 90671bc
commit 356b0c7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/megamek/src/megamek/client/ui/swing/ClientGUI.java b/megamek/src/megamek/client/ui/swing/ClientGUI.java
@@ -936,7 +936,7 @@ public void actionPerformed(ActionEvent event) {
                 bv.refreshDisplayables();
                 break;
             case VIEW_TOGGLE_CF_WARNING:
-                ConstructionFactorWarning.handleActionPerformed(client.getGame(), bv);
+                ConstructionFactorWarning.handleActionPerformed();
                 break;
             case VIEW_MOVE_ENV:
                 if (curPanel instanceof MovementDisplay) {

diff --git a/megamek/src/megamek/common/ConstructionFactorWarning.java b/megamek/src/megamek/common/ConstructionFactorWarning.java
@@ -39,7 +39,7 @@ public class ConstructionFactorWarning {
 	 * Handler for ClientGUI actionPerformed event. Encapsulates
 	 * as much Construction Factory Warning logic possible.
 	 */
-	public static void handleActionPerformed(Game g, BoardView bv) {
+	public static void handleActionPerformed() {
 		toggleCFWarning();
 	}
 

diff --git a/megamek/unittests/megamek/common/ConstructionFactorWarningTest.java b/megamek/unittests/megamek/common/ConstructionFactorWarningTest.java
@@ -60,12 +60,9 @@ public void testSetPreferenceForCFWarningIndicator() {
 	public void testActionPerformedHandlerTogglesCFWarningPref() {
 		// Test logic used when an action is performed.
 		// When the action to toggle CF Warning is called, the state of the toggle should flip.
-		BoardView bv = mock(BoardView.class);
-		Game g = mock(Game.class);
-		when(g.getPhase()).thenReturn(GamePhase.DEPLOYMENT);
 		boolean expected = !GUIP.getShowCFWarnings();
 
-		ConstructionFactorWarning.handleActionPerformed(g, bv);
+		ConstructionFactorWarning.handleActionPerformed();
 
 		//Expect to see the toggle state for CF Warning toggled after the handler is called.
 		assertEquals(expected, GUIP.getShowCFWarnings());