Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-player killfeed modal #125

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TheLazySquid
Copy link
Contributor

I noticed there was an unused endpoint in the backend for the killfeed and figured that it could be useful to see the history of a player's kills in order to make a verdict (for example to see whether a sniper has hit any bodyshots). I did my best to recreate the killfeed entries as faithfully as I could, but all the ids for kills were gathered in one long, boring afternoon and there may be mistakes here and there. (If an icon is missing it will fall back to the default skull).

Each killfeed icon is a few kilobytes, with all 200ish totaling to around a megabyte.

image

@megascatterbomb
Copy link
Contributor

Couple quirks:

  • The killfeed doesn't reset when switching maps/servers. Is this something we'd want to occur?
  • The killfeed uses the player's team at the time of opening the modal to determine the team coloring for all kill events. I'd consider adding a team property to each killfeed entry so that discrepancies don't occur, though this may require further development on the backend to do cleanly.

@TheLazySquid
Copy link
Contributor Author

Fixing either of those cleanly would probably require some work on the backend, unless there's some stuff I don't know about. It's also worth noting that the system of short polling the entire killfeed every second is really innefficient- after a few hours of play the killfeed will need to transfer a few hundred kilobytes per second.

With that said, I know next to no Rust, so I unfortunately won't be able to do much of anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants