Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gosh does not support golang 1.8 or higher #27

Open
kklipsch opened this issue Oct 9, 2017 · 0 comments
Open

gosh does not support golang 1.8 or higher #27

kklipsch opened this issue Oct 9, 2017 · 0 comments

Comments

@kklipsch
Copy link
Contributor

kklipsch commented Oct 9, 2017

Go 1.8 and greater changed the behavior of os.Rename such that it will now fail if you are trying to rename to a destination that already exists. We are doing so because we are using the temporary folder libraries to get atomically unique names and then renaming into the directories that get created.

We can:

  • use TempDir and delete the folder it creates, losing atomic names
  • make our own atomically random temp dir name function
  • figure out how to move into the folder correctly instead of rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant