Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set turn motor position to absolute position at start up #14

Merged
merged 9 commits into from
Feb 17, 2024
Merged

Set turn motor position to absolute position at start up #14

merged 9 commits into from
Feb 17, 2024

Conversation

suryatho
Copy link
Contributor

  • Use pre-defined members for control rather than creating new control request each cycle
  • Use feedforward input from module always
  • Run drive and turn with amps
  • Make every control request one shot
  • Make alerts for drive and turn disconnected
  • Rename methods in ModuleIO

@suryatho
Set turn motor position to absolute position at start up
f5dd2dd 
Use pre-defined members for control rather than creating new control request each cycle
Use feedforward input from module always
Run drive and turn with amps
Make every control request one shot
Make alerts for drive and turn disconnected
Rename some methods in ModuleIO
@suryatho suryatho self-assigned this Feb 14, 2024
@suryatho suryatho linked an issue Feb 14, 2024 that may be closed by this pull request
Get krakens going #15
Closed
5 tasks
@jwbonner
Copy link
Member

I think the only thing left is fixing the robot in Constants.

jwbonner
jwbonner previously approved these changes Feb 17, 2024
View reviewed changes
@jwbonner jwbonner merged commit b842a67 into main Feb 17, 2024
2 checks passed
@jwbonner jwbonner deleted the feature-kraken-drive branch February 17, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwbonner jwbonner jwbonner approved these changes

Assignees

@suryatho suryatho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get krakens going
2 participants
@suryatho @jwbonner