Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract every hard coded String to string.xml resource #8

Open
Me-Abhishek-patel opened this issue Oct 3, 2020 · 7 comments
Open

Comments

@Me-Abhishek-patel
Copy link
Owner

Extract every hard coded string to string.xml resource file
So that it can be translated and resused.

@matheuscr30
Copy link

Can u assign this to me?

@Me-Abhishek-patel
Copy link
Owner Author

@matheuscr30 yes sure

@TomerPacific
Copy link
Contributor

@Me-Abhishek-patel , if @matheuscr30 is busy, I can help with this issue.

@matheuscr30 matheuscr30 removed their assignment Oct 11, 2020
@matheuscr30
Copy link

@Me-Abhishek-patel go on, the path is free now

@TomerPacific
Copy link
Contributor

@matheuscr30 , did you open a branch for this and make some progress or should I start fresh?

@TomerPacific
Copy link
Contributor

@Me-Abhishek-patel , I have opened a PR.

@TomerPacific
Copy link
Contributor

@Me-Abhishek-patel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants