Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle button should set progress to 100 #6

Open
Me-Abhishek-patel opened this issue Oct 3, 2020 · 7 comments
Open

toggle button should set progress to 100 #6

Me-Abhishek-patel opened this issue Oct 3, 2020 · 7 comments
Labels
beginer bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@Me-Abhishek-patel
Copy link
Owner

Actual Behavior: Toggle button doesn't do anything.
Expected Behavior: should set progress to 100.

WhatsApp Image 2020-10-03 at 1 24 56 PM
WhatsApp Image 2020-10-03 at 1 24 41 PM

@Me-Abhishek-patel Me-Abhishek-patel added bug Something isn't working good first issue Good for newcomers hacktoberfest beginer labels Oct 3, 2020
@TheDheeraj007
Copy link

Hi,
Can I work on this issue?

@Me-Abhishek-patel
Copy link
Owner Author

@TheDheeraj007 yes, go ahead

@Me-Abhishek-patel
Copy link
Owner Author

@TheDheeraj007 are u still working on it?
any update?

@TheDheeraj007
Copy link

@Me-Abhishek-patel Yes, I'm working on it.
Being new to Android, currently understanding the codebase. Will keep you posted on updates.

@TheDheeraj007
Copy link

TheDheeraj007 commented Oct 6, 2020

Hi @Me-Abhishek-patel can you please advise me on this:
On setting the Toggle button we should make the task progress to 100% in the DB.

  1. Now there is a method updateProgress(int progress) in TaskDetails, so I can make a similar method in TaskAdopter and do the same. (Since toggle resides in the TaskAdopter)
  2. Or we should expose this update progress(int progress) in a common utility class so that we don't rewrite the same method again. What do you suggest I should go with?

@Me-Abhishek-patel
Copy link
Owner Author

@TheDheeraj007 2 nd

Hi @Me-Abhishek-patel can you please advise me on this:
On setting the Toggle button we should make the task progress to 100% in the DB.

  1. Now there is a method updateProgress(int progress) in TaskDetails, so I can make a similar method in TaskAdopter and do the same. (Since toggle resides in the TaskAdopter)
  2. Or we should expose this update progress(int progress) in a common utility class so that we don't rewrite the same method again. What do you suggest I should go with?

@2nd approach is better... Go with it

@TheDheeraj007
Copy link

Test-cases that I'll be covering for the onset of toggle:
1)Task progress to be 100% (Done)
2)Project progress to be updated accordingly (in progress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginer bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants