Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customgui_quicktab_r19 Doesn't Remove Multiple or Add Correctly #6

Open
dskeithbuck opened this issue Sep 4, 2019 · 1 comment
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Low-prio Will be fixed when get time

Comments

@dskeithbuck
Copy link

Here are the bugs/issues in action:
QuickTab

1: After Removing one tab, you cannot remove another.
2. After running Flush All, all subsequent tabs are named Third Tab and can't be deleted.

@gr4ph0s gr4ph0s added enhancement New feature or request good first issue Good for newcomers labels Sep 6, 2019
@gr4ph0s gr4ph0s self-assigned this Sep 6, 2019
@gr4ph0s
Copy link
Contributor

gr4ph0s commented Sep 6, 2019

Hi, this is exactly the purpose of the example.
The Remove Button, as explained in the code, removes the tab called "First Tab".
And the Add Button adds a new tab called "Third Tab" in any case.

The purpose is to show to handle a dynamic number of tabs. How you handle data is up to the developer. However, I agree some improvement can be done.

So thanks for flagging, it's low prio.
Cheers,
Maxime.

@gr4ph0s gr4ph0s added the Low-prio Will be fixed when get time label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Low-prio Will be fixed when get time
Projects
None yet
Development

No branches or pull requests

2 participants