Problem with --no-strict-syntax and --use-pades-lta

[pquL1]

Hi,

I'm not sure if this is intended behavior or a bug: I have a PDF that I cannot sign with a strict syntax check. Adding --no-strict-syntax resolves the issue, but not when I also use --use-pades-lta, then I get the same error as without the first parameter:

Error: Failed to read PDF file in strict mode; rerun with --no-strict-syntax to try again.
Error message: Illegal generation 4294967295 for object ID 0.

Is Pades LTA incompatible with non-strict syntax checking? Or is the --no-strict-syntax maybe lost on the way to the extra time stamp?

Greetings

[edispring]

Hi Matthias,

I think I found the reason.
In the method PdfTBSDocument.async_finish_signing calling post_sign.post_signature_processing a new IncrementalPdfFileWriter is instantiated and there is no possibility to pass strict=False in this case.

pyHanko/pyhanko/sign/signers/pdf_signer.py

Line 2857 in 056e684

w = IncrementalPdfFileWriter(output)

The same applies when calling PdfTBSDocument.async_sign_pdf.

Is it possible to add the strict option to these methods?
@MatthiasValvekens Should I make a PR?

Best,
Edi

[MatthiasValvekens]

That does sound like a good suggestion. Be my guest!

[pquL1]

I just noticed that the fix has already been released a while ago! Really cool, thanks a lot @edispring and @MatthiasValvekens 👏