Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interiors with no lights are causing script errors #1070

Open
parar020100 opened this issue Mar 9, 2024 · 3 comments
Open

Interiors with no lights are causing script errors #1070

parar020100 opened this issue Mar 9, 2024 · 3 comments

Comments

@parar020100
Copy link
Collaborator

A while ago some interiors, which didn't have any T.Light specified, were broken

This might be related (reported by @smf64yt in discord):
image

discord discussion

@MattJeanes
Copy link
Owner

Is this our responsibility to fix? Perhaps we could add a validation step at least in the config to prevent them from being added and throwing errors, forcing the addon developer to update their addon rather than working around it for them

@parar020100
Copy link
Collaborator Author

parar020100 commented Mar 11, 2024

Is this our responsibility to fix?

They broke in one of our updates, and some TARDISes were not supposed to have lights originally, so yeah, I think we should add a condition for that (should be easy enough)

@parar020100 parar020100 changed the title Fix interiors without light data Interiors with no lights are causing script errors Mar 11, 2024
@parar020100 parar020100 added this to the Lighting update milestone Mar 11, 2024
@MattJeanes
Copy link
Owner

Ah okay, if it was working but we broke it that's fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

2 participants