fix: Incorrect touch position measurement in modals #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
MatiPl01
pushed a commit
that referenced
this pull request
Feb 26, 2025
# [1.3.0](v1.2.1...v1.3.0) (2025-02-26) ### Bug Fixes * Incorrect touch position measurement in modals ([#282](#282)) ([c67ee84](c67ee84)) * Quick fix for added item flickering ([#275](#275)) ([286cac2](286cac2)) * Some flex reordering issues ([#224](#224)) ([54ac234](54ac234)) ### Features * Add horizontal direction support to the Sortable Grid ([#277](#277)) ([8706955](8706955)) * Container overflow customization ([#278](#278)) ([fb6de0f](fb6de0f)) * Customizable reorder trigger origin ([#274](#274)) ([21a23ce](21a23ce)) * Implement better grid reordering ([#280](#280)) ([c7e5daf](c7e5daf))
|
🎉 This issue has been resolved in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes incorrect touch position measurement within the sortable container caused by reanimated's
measurefunction. It changes the calculation logic not to use themeasurefunction (or to use it twice, for the custom handle and the container measurement - the invalid measurement offset will be gone after subtraction of 2measureresults).Example recordings
Screen.Recording.2025-02-26.at.02.05.40.mp4
Screen.Recording.2025-02-26.at.01.57.25.mp4