[BUG] setting LCD_INFO_SCREEN_STYLE on non HAS_MARLINUI_HD44780 screen no longer errors

[ellensp]

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

setting LCD_INFO_SCREEN_STYLE on non HAS_MARLINUI_HD44780 screen no longer errors
now it just quietly undefines LCD_INFO_SCREEN_STYLE
Added in PR #27346 6 days ago

#if !HAS_MARLINUI_HD44780
  #undef LCD_INFO_SCREEN_STYLE
#endif

Instead of triggering the following sanity check to warn the user

/**
 * LCD Info Screen Style
 */
#if LCD_INFO_SCREEN_STYLE > 0
  #if HAS_MARLINUI_U8GLIB || LCD_WIDTH < 20 || LCD_HEIGHT < 4
    #error "Alternative LCD_INFO_SCREEN_STYLE requires 20x4 Character LCD."
  #elif LCD_INFO_SCREEN_STYLE > 2
    #error "LCD_INFO_SCREEN_STYLE only has options 0 (Classic), 1 (Průša), and 2 (CNC)."
  #endif
#endif

Bug Timeline

since #27346

Expected behavior

This should warn the user that LCD_INFO_SCREEN_STYLE is not compatible with their display

Actual behavior

It silently removes LCD_INFO_SCREEN_STYLE and the user complains that LCD_INFO_SCREEN_STYLE is not working.
(Already happened today on Marlin Discord)

Version of Marlin Firmware

Bugfix-2.1.x

Electronics

any

LCD/Controller

any non char display

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

[ellensp]

This is still an issue