Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Improvements #7

Closed
wants to merge 8 commits into from
Closed

Small Improvements #7

wants to merge 8 commits into from

Conversation

cookie0o
Copy link
Contributor

added a auto Streamer mode detection and made some small improvements to the readme.md

Copy link
Owner

@Mark7888 Mark7888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing, but this commit has some major flaws:

  1. Naming conventions: https://peps.python.org/pep-0008/#function-and-variable-names
    Functions are lower case letters with underscores between the words. Like def is_streamer_mode(). Also, the is_streamer_mode function supposed to be inside the Sonar class, not next to it.

  2. Why did you copy the whole sonar.py in a new file before adding new features to it? You could just edit the one in src/steelseries_sonar_py/sonar.py

  3. What does _ = None does in the 7th row? Why is it neccessary there?

@cookie0o
Copy link
Contributor Author

Thank you for contributing, but this commit has some major flaws:

1. Naming conventions: https://peps.python.org/pep-0008/#function-and-variable-names
   Functions are lower case letters with underscores between the words. Like `def is_streamer_mode()`. Also, the `is_streamer_mode` function supposed to be inside the `Sonar` class, not next to it.

2. Why did you copy the whole `sonar.py` in a new file before adding new features to it? You could just edit the one in `src/steelseries_sonar_py/sonar.py`

3. What does `_ = None` does in the 7th row? Why is it neccessary there?
  1. Didn't know it will change the Name

  2. My Stupidity

  3. Leftover from testing

Will change all the things and make a new commit, but thanks for the comment!

@cookie0o cookie0o closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants