How to make Csla 9 not use legacy DataPortal_XYZ methods?

[hoangcuongvn]

I upgrading my project that used Csla 8 to the new Csla 9. In Csla 8, all legacy DataPortal_XYZ and Child_XYZ methods are ignored. So in my project, many classes are declared like below and they worked fine as expected. But Csla 9 suddenly supports back those legacy methods and all my classes now crash. E.g if I call _portal.Execute()

• In Csla 8, the method XCommandBase.execute() is invoked as expected
• But in Csla 9, the method DataPortal_Execute() is invoked => this causes the app works incorrectly.

Is it possible (e.g through configuration) to make Csla 9 not use those legacy methods?

public abstract XCommandBase<T>: CommandBase<T>
{
    [Execute]
    private Task execute()
    {
      return DataPortal_ExecuteAsync();
    }

    protected virtual void DataPortal_Execute()
    {
      throw new NotImplementedException(nameof(DataPortal_Execute));
    }

    protected virtual Task DataPortal_ExecuteAsync()
    {
      DataPortal_Execute();
      return Task.CompletedTask;
    }
}

[rockfordlhotka]

Can you provide a repro for this behavior?

I just searched the v9.x codebase and the only use of "DataPortal_Execute" is in the analyzer that tells you not to use it.

[hoangcuongvn]

I created a repo in the link below.
https://drive.google.com/file/d/1dRzBcr9MM21TAahlNpA91-WZyH_2GIgM/view?usp=drive_link

There are 2 test projects ConsoleApp.Csla8 and ConsoleApp.Csla9 with the same code. One uses Csla 8, the other uses Csla 9.

• In ConsoleApp.Csla8, MyCommand.DataPortal_ExecuteAsync is invoked as expected.
• In ConsoleApp.Csla9, MyCommand.DataPortal_ExecuteAsync is NOT invoked.

  abstract class XCommandBase<T> : CommandBase<T>
     where T : XCommandBase<T>
  {
    [Execute]
    private Task execute()
    {
      return DataPortal_ExecuteAsync();
    }

    protected virtual void DataPortal_Execute()
    {
      throw new NotImplementedException(nameof(DataPortal_Execute));
    }

    protected virtual Task DataPortal_ExecuteAsync()
    {
      DataPortal_Execute();
      return Task.CompletedTask;
    }
  }

  class MyCommand : XCommandBase<MyCommand>
  {
    protected override Task DataPortal_ExecuteAsync()
    {
      Console.WriteLine("This method should be invoked");
      return Task.CompletedTask;
    }
  }

[rockfordlhotka]

It turns out that this was an intentional change, with the thought process documented here: #4090

In your base class do this:

    [Execute]
    protected virtual Task execute()
    {
      return DataPortal_ExecuteAsync();
    }

In your subclass do this:

        [Execute]
        protected override Task execute()
        {
            return base.execute();
        }

[hoangcuongvn]

The strange thing is that data portal invoking in Csla 8 works properly as expected. If possible, Csla 9 should keep using the same invoking as Csla 8. Or it should offer a way to choose the old Csla 8 invoking e.g through configuration.