Skip to content

Commit

Permalink
Fix some warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
ManlyMarco committed Sep 25, 2024
1 parent db93983 commit 703c4d8
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 25 deletions.
4 changes: 1 addition & 3 deletions RuntimeUnityEditor.Bepin6.IL2CPP/LogViewer/LogViewerEntry.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
using System;
using System.Diagnostics;
using System.Linq;
using System.Diagnostics;
using System.Reflection;
using System.Text;
using BepInEx.Logging;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<Nullable>disable</Nullable>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>

<OutputPath>..\bin\IL2CPP\</OutputPath>
Expand Down
6 changes: 3 additions & 3 deletions RuntimeUnityEditor.Core/Features/Gizmos/lib/Gizmos.cs
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ public static Vector3 Offset
{
get
{
const string Delim = ",";
//const string Delim = ",";
if (_offset == null)
{
//todo use config
Expand All @@ -241,8 +241,8 @@ public static Vector3 Offset
}
set
{
const string Delim = ",";
if (_offset != value)
//const string Delim = ",";
//if (_offset != value)
{
_offset = value;
//todo use config
Expand Down
13 changes: 0 additions & 13 deletions RuntimeUnityEditor.Core/Features/Gizmos/lib/GizmosInstance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ internal static GizmosInstance GetOrCreate()
{
if (hotReloaded || !instance)
{
bool markDirty = false;
GizmosInstance[] gizmosInstances = FindObjectsOfType<GizmosInstance>();
for (int i = 0; i < gizmosInstances.Length; i++)
{
Expand All @@ -95,7 +94,6 @@ internal static GizmosInstance GetOrCreate()
else
{
DestroyImmediate(gizmosInstances[i]);
markDirty = true;
}
}
}
Expand All @@ -105,18 +103,7 @@ internal static GizmosInstance GetOrCreate()
{
instance = new GameObject(typeof(GizmosInstance).FullName).AddComponent<GizmosInstance>();
instance.gameObject.hideFlags = HideFlags.HideInHierarchy | HideFlags.HideInInspector;

markDirty = true;
}

#if UNITY_EDITOR
//mark scene as dirty
if (markDirty && !Application.isPlaying)
{
Scene scene = SceneManager.GetActiveScene();
EditorSceneManager.MarkSceneDirty(scene);
}
#endif

hotReloaded = false;
}
Expand Down
2 changes: 1 addition & 1 deletion RuntimeUnityEditor.Core/Utils/ThreadingExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
namespace RuntimeUnityEditor.Core.Utils
{
/// <summary>
/// Convenience extensions for utilizing multiple threads and using the <see cref="ThreadingHelper"/>.
/// Convenience extensions for utilizing multiple threads.
/// </summary>
public static class ThreadingExtensions
{
Expand Down
8 changes: 4 additions & 4 deletions RuntimeUnityEditor.Core/Windows/ChangeHistory/Change.cs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static IChange MemberAssignment<TObj, TVal>(TObj target, TVal newValue, M
/// </summary>
/// <typeparam name="TObj">Type of the object that has its member(s) modified</typeparam>
/// <typeparam name="TVal">Type of the value to be changed</typeparam>
/// <param name="actionNameFormat">String format of how this change is represented in the Change History window. {0} inserts type name of <see cref="TObj"/>, while {1} inserts <paramref name="newValue"/> (format string can be used, e.g. {1:00})</param>
/// <param name="actionNameFormat">String format of how this change is represented in the Change History window. {0} inserts type name of <typeparamref name="TObj"/>, while {1} inserts <paramref name="newValue"/> (format string can be used, e.g. {1:00})</param>
/// <param name="target">Object that has its member(s) modified</param>
/// <param name="newValue">New value to be set</param>
/// <param name="set">Action used to set the new value</param>
Expand All @@ -91,11 +91,11 @@ public static IChange WithoutUndo<TObj, TVal>(string actionNameFormat, TObj targ
/// <summary>
/// Assigns a new value by using the set delegate and tracks the change in the Change History window.
/// Undo is possible by providing an undo value, by using a custom action, or by using the get delegate to automatically get the original value.
/// If none of the undo options are provided, undoing the change will set it to the default value of <see cref="TVal"/>.
/// If none of the undo options are provided, undoing the change will set it to the default value of <typeparamref name="TVal"/>.
/// </summary>
/// <typeparam name="TObj">Type of the object that has its member(s) modified</typeparam>
/// <typeparam name="TVal">Type of the value to be changed</typeparam>
/// <param name="actionNameFormat">String format of how this change is represented in the Change History window. {0} inserts type name of <see cref="TObj"/>, while {1} inserts <paramref name="newValue"/> (format strings can be used, e.g. {0:00.0})</param>
/// <param name="actionNameFormat">String format of how this change is represented in the Change History window. {0} inserts type name of <typeparamref name="TObj"/>, while {1} inserts <paramref name="newValue"/> (format strings can be used, e.g. {0:00.0})</param>
/// <param name="target">Object that has its member(s) modified</param>
/// <param name="newValue">New value to be set</param>
/// <param name="set">Action used to set the new value</param>
Expand Down Expand Up @@ -137,7 +137,7 @@ private static IChange Do<TObj, TVal>(string actionNameFormat, TObj target, TVal
/// Do an action and track it in the Change History window. Optionally undoable.
/// </summary>
/// <typeparam name="TObj">Type of the object that the action uses</typeparam>
/// <param name="actionNameFormat">String format of how this change is represented in the Change History window. {0} inserts type name of <see cref="TObj"/> (format strings can be used, e.g. {0:00.0})</param>
/// <param name="actionNameFormat">String format of how this change is represented in the Change History window. {0} inserts type name of <typeparamref name="TObj"/> (format strings can be used, e.g. {0:00.0})</param>
/// <param name="target">Object that has its member(s) modified</param>
/// <param name="action">Action invoked on the target object</param>
/// <param name="undoAction">Action invoked on the target object to undo the change</param>
Expand Down
2 changes: 2 additions & 0 deletions RuntimeUnityEditor.Core/Windows/Inspector/Inspector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ public string SearchString
private bool _showProperties = true;
private bool _showMethods = true;
private bool _showEvents = true;
#if IL2CPP
private bool _showNative;
#endif
private bool _showDeclaredOnly;
private bool _showTooltips = true;

Expand Down

0 comments on commit 703c4d8

Please sign in to comment.