Remove hardcoded types in favor of a supports feature check

[Fryguy]

Part of #19440

Depends on

• Add missing supports :provisioning for templates manageiq-providers-kubevirt#167
• Move supports :provisioning to base class for other descendants manageiq-providers-openstack#628

@agrare Please review.

[Fryguy]

[2] pry(main)> ManageIQ::Providers::CloudManager::Template.descendants.select(&:supports_provisioning?).map(&:name)
=> ["ManageIQ::Providers::Amazon::CloudManager::Template",
 "ManageIQ::Providers::Azure::CloudManager::Template",
 "ManageIQ::Providers::Google::CloudManager::Template",
 "ManageIQ::Providers::IbmCloud::PowerVirtualServers::CloudManager::Template",
 "ManageIQ::Providers::Openstack::CloudManager::BaseTemplate",
 "ManageIQ::Providers::Openstack::CloudManager::Template",
 "ManageIQ::Providers::Openstack::CloudManager::VolumeSnapshotTemplate",
 "ManageIQ::Providers::Openstack::CloudManager::VolumeTemplate"]

[3] pry(main)> ManageIQ::Providers::InfraManager::Template.descendants.select(&:supports_provisioning?).map(&:name)
=> ["ManageIQ::Providers::Kubevirt::InfraManager::Template",
 "ManageIQ::Providers::Redhat::InfraManager::Template",
 "ManageIQ::Providers::Microsoft::InfraManager::Template",
 "ManageIQ::Providers::Vmware::InfraManager::Template"]

Note that ManageIQ::Providers::Openstack::CloudManager::BaseTemplate is in the list, but it shouldn't affect the query. i can move it into the specific subclasses in the openstack plugin if that's preferable (see ManageIQ/manageiq-providers-openstack#628)

[Fryguy]

cc @jaywcarman

[miq-bot]

Checked commit Fryguy@9792d9e with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
3 files checked, 0 offenses detected
Everything looks fine. ⭐

[Fryguy]

Not sure how I could add specs for this... I don't really like the current spec

manageiq/spec/models/miq_template_spec.rb

Lines 48 to 62 in 349f28c

	it "#supports_provisioning?" do
	template = FactoryBot.create(:template_openstack)
	FactoryBot.create(:ems_openstack, :miq_templates => [template])
	expect(template.supports_provisioning?).to be_truthy
	template = FactoryBot.create(:template_openstack)
	expect(template.supports_provisioning?).to be_falsey
	template = FactoryBot.create(:template_microsoft)
	expect(template.supports_provisioning?).to be_falsey
	template = FactoryBot.create(:template_microsoft)
	FactoryBot.create(:ems_openstack, :miq_templates => [template])
	expect(template.supports_provisioning?).to be_truthy
	end

because it's not very pluggable. Was thinking maybe each plugin should have their own method that checks that's it's in the eligible list? WDYT?

[agrare]

Yeah since we're getting rid of the list in core and moving to supports_feature in the plugins, makes sense the specs would move to the plugins also

[Fryguy]

Ok, maybe I should do that in a follow up PR, because that will entail a lot more moving parts.