Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass ResourcePools #19529

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 18, 2019

Subclass ResourcePools to allow for provider specifics (e.g. provider_object/connection and ems_ref_obj mixins) to be added for VMware and not have to be in core.

Depends:

Dependent:

Cross Repo Tests: ManageIQ/manageiq-cross_repo-tests#13

#19440

@miq-bot
Copy link
Member

miq-bot commented Nov 18, 2019

Checked commit agrare@abd6350 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy
Copy link
Member

Fryguy commented Nov 18, 2019

@agrare Can you add in UI and API tests to your cross repo matrix?

@agrare
Copy link
Member Author

agrare commented Nov 18, 2019

@Fryguy added UI and API and it is green

@chessbyte chessbyte merged commit 21cf5b9 into ManageIQ:master Nov 19, 2019
@agrare agrare deleted the subclass_resource_pool branch November 19, 2019 14:05
@agrare agrare added this to the Sprint 125 Ending Nov 25, 2019 milestone Nov 19, 2019
@agrare agrare mentioned this pull request Nov 19, 2019
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants