Subclass ResourcePools #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
agrare
force-pushed
the
subclass_resource_pools
branch
3 times, most recently
from
f57c3cb to
8c92acb
Compare
bdunne
reviewed
Nov 18, 2019
| let(:resource_pool_stub) { migration_stub(:ResourcePool) } | ||
|
|
||
| migration_context :up do | ||
| it "migrates resource pools from all supported providers" do |
There was a problem hiding this comment.
It would probably also be good to have a test for a record that isn't changed by the migration.
agrare
force-pushed
the
subclass_resource_pools
branch
from
8c92acb to
5ec9b3d
Compare
|
Checked commits agrare/manageiq-schema@1dcf0e4~...5ec9b3d with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20191118161319_subclass_resource_pools.rb
|
|
This broke the UI 😢, see ManageIQ/manageiq-ui-classic#6425 |
|
@skateman we tested this with the other PRs linked to make sure the UI was still working with all of the PRs applied. Just got caught in the middle of a set of PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some provider specifics to ResourcePools which should not live in core
Core issue: ManageIQ/manageiq#19529