Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to use volume for oracle #43

Closed
albfan opened this issue May 10, 2017 · 8 comments
Closed

Avoid to use volume for oracle #43

albfan opened this issue May 10, 2017 · 8 comments

Comments

@albfan
Copy link
Contributor

albfan commented May 10, 2017

If you remove

VOLUME ["/u01/app/oracle"]

from Dockerfile, it will be not mounted by default (empty) so you can have static databases

  1. Import a dump
  2. save a tag with docker commit
  3. Share image tagged for CI, testing, etc...

albfan@3a9a3b5

@MaksymBilenko
Copy link
Owner

@albfan there was some issues on different platforms. Could you please play around Dockerfile/VOLUME and test it on Windows/Mac/Linux?
Thank you

@MaksymBilenko
Copy link
Owner

@albfan it makes sense...

@albfan
Copy link
Contributor Author

albfan commented May 10, 2017

Sure, I can report feedback for Windows/Linux

@albfan
Copy link
Contributor Author

albfan commented May 10, 2017

Windows working correctly. I think that's enough to test this.

The only concern is to clearly document how to use existing databases with volume, but README is well documented

@albfan
Copy link
Contributor Author

albfan commented May 10, 2017

Just seen: 4dd6591

@albfan albfan closed this as completed May 10, 2017
@filippetrovic
Copy link

But now we can not configure this volume from Kitematic.
Can we make some compromise solution?

@albfan
Copy link
Contributor Author

albfan commented Feb 19, 2018

Opps! docker/kitematic#1923.

@filippetrovic add a volume because a third party app does not work without it seems wrong. You can always extend this dockerfile to have your volume but that's only a workaround for kitematic (someone needs to implement an add volume)

@filippetrovic
Copy link

Same thoughts here.
But I'm not sure what is semantic of VOLUME keyword in Dockerfile.
However, I do not insist on reverting this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants