Turn mgc cli version into a variable/input of the run tests workflow #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fczuardi
force-pushed
the
mgc-cli-version-as-input
branch
2 times, most recently
from
20b19c5 to
e586786
Compare
Updating the mgc version today requires changes in two places of a hardcoded string. And we dont have a way to use the manually triggered tests with different versions of the mgc. This patch turns the version into a variable that can be passed as an argument to the workflow, what can make it easier to write test matrices including different versions of the cli in the future, and make it simple to change the default version to be used when new releases comes.
fczuardi
force-pushed
the
mgc-cli-version-as-input
branch
from
e586786 to
84c6ebe
Compare
folkzb
approved these changes
Feb 5, 2025
luizantonio26
approved these changes
Feb 5, 2025
mcruvinel
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the mgc version today requires changes in two places of a hardcoded string. And we dont have a way to use the manually triggered tests with different versions of the mgc.
This patch turns the version into a variable that can be passed as an argument to the workflow, what can make it easier to write test matrices including different versions of the cli in the future, and make it simple to change the default version to be used when new releases comes.