More policy tests #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fczuardi
force-pushed
the
more-policy-tests
branch
6 times, most recently
from
8442998 to
d050a8b
Compare
fczuardi
force-pushed
the
more-policy-tests
branch
22 times, most recently
from
bac2c1c to
199e94d
Compare
fczuardi
force-pushed
the
split-pr-ci
branch
2 times, most recently
from
66b03c8 to
f3c9069
Compare
fczuardi
force-pushed
the
more-policy-tests
branch
from
2f659de to
cf9c449
Compare
fczuardi
force-pushed
the
more-policy-tests
branch
from
cf9c449 to
f1ba930
Compare
One policy test used a bucket name fixture that could not have a proper teardown because the teardown of the fixture didnt included a policy removal.
There is still a bad region in MagaluCloud that takes more than a minute to make the bucket policy effective, even when the get bucket policy request returning the expected correct policy. This patch introduces a new config for tweaking how many seconds the tests should wait after putting or deleting a bucket policy. This patch also adds some very ugly hackish code that I am not proud of, to make our tests more flexible, and a lot more slow to finish as well.
The goal of this project is to have descriptive tests, with markdown paragraphs explaining the examples, and not only pytests that runs but are undocumented. This patch improves one of our documents related to bucket policy, the policies_test.py one.
The docs about policy only ran on pytest
fczuardi
force-pushed
the
more-policy-tests
branch
2 times, most recently
from
cc43bff to
520f1dc
Compare
fczuardi
force-pushed
the
more-policy-tests
branch
from
520f1dc to
c2ea82f
Compare
fczuardi
added
the
pr:ask
folkzb
approved these changes
Feb 7, 2025
folkzb
approved these changes
Feb 7, 2025
folkzb
approved these changes
Feb 7, 2025
folkzb
approved these changes
Feb 7, 2025
folkzb
approved these changes
Feb 7, 2025
folkzb
approved these changes
Feb 7, 2025
folkzb
approved these changes
Feb 7, 2025
folkzb
approved these changes
Feb 7, 2025
folkzb
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Em preparação para as novas actions, relativas a BucketLocking que poderão ser utilizadas em policies. Ajustes nos testes existentes foram necessários.
Aproveitei também para aproximar os testes de policy, que anteriormente não funcionavam como documentação executável (nao continha paragrafos em Markdown) para, na medida do possível serem notebooks minimamente coerentes, então este patch contém alguns refactors além do suporte a actions de locking nas policies.