Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): Bug 1186 - url sign error #1346

Merged
merged 3 commits into from
Feb 18, 2025
Merged

fix(list): Bug 1186 - url sign error #1346

merged 3 commits into from
Feb 18, 2025

Conversation

GuiLorencato
Copy link
Collaborator

@GuiLorencato GuiLorencato commented Feb 12, 2025

What does this PR do?

Diferença entre a url da aws-cli e a da mgc-cli

Ao tentar listar um path com prefixo, e o prefixo contendo espaço, ocorre erro de assinatura, a mgc cli esta encodando os espaços como "+" ao inves de "%20"

Como replicar:

  • Subir um path que contenha espaços em um bucket
  • Tentar lista-lo com o comando abaixo

mgc os objects list "test-space/test with space/"

-Error: (AccessDenied) 403 Forbidden - Credentials or specified url is malformed.

O problema esta no encode da request url

How Has This Been Tested?

  • Unit Tests: Describe the unit tests you have written and their outcomes.

Solved encoding problem by path encoding and not query encoding the url

  • Integration Tests: Detail the integration tests performed and their results.

  • Manual Testing: Explain the manual testing process, including steps taken and evidence such as screenshots or logs.

Checklist

  • I have run Pre commit pre-commit run --all-files
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots/Videos

@GuiLorencato GuiLorencato added the bug Something isn't working label Feb 12, 2025
@GuiLorencato GuiLorencato self-assigned this Feb 12, 2025
@GuiLorencato GuiLorencato requested a review from a team as a code owner February 12, 2025 20:20
@publi0 publi0 merged commit 2f82f3d into main Feb 18, 2025
5 checks passed
@publi0 publi0 deleted the fix/url branch February 18, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants