Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore - improve error message when using access token to authenticate #1266

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

publi0
Copy link
Collaborator

@publi0 publi0 commented Nov 22, 2024

What does this PR do?

todo

Improvements to error handling and logging:

  • mgc/core/auth/auth.go: Added import for the errors package to handle error creation.
  • mgc/core/auth/auth.go: Enhanced the AccessToken method to log errors using logger().Errorw and return more descriptive error messages when failing to refresh the access token.

How Has This Been Tested?

  • Unit Tests: Describe the unit tests you have written and their outcomes.
    Unit tests ok

  • Manual Testing: Explain the manual testing process, including steps taken and evidence such as screenshots or logs.
    Manual testing ok

Checklist

  • I have run Pre commit pre-commit run --all-files
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots/Videos

@publi0 publi0 added enhancement New feature or request cli cli related improvements terraform terraform related issues labels Nov 22, 2024
@publi0 publi0 self-assigned this Nov 22, 2024
@publi0 publi0 requested a review from a team as a code owner November 22, 2024 18:41
@publi0 publi0 marked this pull request as draft November 22, 2024 18:41
@publi0 publi0 requested a review from Copilot December 11, 2024 14:07

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli cli related improvements enhancement New feature or request terraform terraform related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants