Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change to insert, switch, replace, RingMap acting on lists #3501

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

pzinn
Copy link
Contributor

@pzinn pzinn commented Sep 29, 2024

This PR fixes two inconsistencies in allowed types:

  • one can now write f \ l for f a RingMap and l any VisibleList, not just List (same as f \ l when f is a Function)
  • insert, switch and replace, which are all based on take, accept BasicList, not just VisibleList, like take itself.

@pzinn
Copy link
Contributor Author

pzinn commented Oct 6, 2024

can this be reviewed/merged? I have other PRs coming that depend on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to update the emacs submodule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh! no

@d-torrance
Copy link
Member

I've always interpreted BasicList objects as things we don't really think of as lists, but just happen to be implemented as lists. In particular, I'm not sure how many "listy" methods outside of the ones defined in the interpreter we want installed for them.

@pzinn
Copy link
Contributor Author

pzinn commented Oct 6, 2024

well, replace is pretty useful no matter what type of BasicList you're dealing with.

@d-torrance
Copy link
Member

well, replace is pretty useful no matter what type of BasicList you're dealing with.

Sounds good to me!

@d-torrance d-torrance merged commit d375948 into Macaulay2:development Oct 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants