Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Popup to Pair Ring When Multiple Rings Are Detected #93

Open
reasje opened this issue Nov 12, 2024 · 7 comments
Open

Display Popup to Pair Ring When Multiple Rings Are Detected #93

reasje opened this issue Nov 12, 2024 · 7 comments
Assignees

Comments

@reasje
Copy link

reasje commented Nov 12, 2024

In the Blueberry Ring DApp, when a user has more than one ring associated with their account, there is currently no prompt to guide them in selecting a ring to pair.

@reasje reasje self-assigned this Nov 12, 2024
@reasje
Copy link
Author

reasje commented Nov 12, 2024

The name of device had overflow and It's fixed, ALso list is optimized when there a large number of bluetooth devices.

@reasje
Copy link
Author

reasje commented Nov 13, 2024

Here is what was happening in Sang's case:
In the logic :

  1. If list is empty or more thatn once device show the bottom sheet
  2. it has 3 seconds timeout in your case you bluetooth is not able to find the any devices within 3 seconds
  3. It opens bottoms sheet
  4. But in matter of mili seconds bluetooth finds the device and adds to bottoms Sheet
    We think that the bottom sheet opened with one device but in realiuty It opened with no device and then found the device
    For reducing the chance of opening one device at bottom sheet we can increase the timeout to 4 - 5 seconds

@reasje
Copy link
Author

reasje commented Nov 13, 2024

Here is what was happening in Sang's case: In the logic :

  1. If list is empty or more thatn once device show the bottom sheet
  2. it has 3 seconds timeout in your case you bluetooth is not able to find the any devices within 3 seconds
  3. It opens bottoms sheet
  4. But in matter of mili seconds bluetooth finds the device and adds to bottoms Sheet
    We think that the bottom sheet opened with one device but in realiuty It opened with no device and then found the device
    For reducing the chance of opening one device at bottom sheet we can increase the timeout to 4 - 5 seconds

We will decide on this.

@reasje
Copy link
Author

reasje commented Nov 13, 2024

@SanghamitraBhowmick1993 Thanks for reporting, Strange behavior on IOS.
Image
Also the device name is availeble on IOS
Image

@reasje
Copy link
Author

reasje commented Mar 3, 2025

@SanghamitraBhowmick1993 Can you plz confirm this has been fixed?

@reasje
Copy link
Author

reasje commented Mar 3, 2025

Current issues :

  1. Some times all bluetooth devices are shown (Fixed)
  2. IOS bluetooth name is missing (Fixed)
  3. Bluetooth list is empty althouhg It is found on phone settings
  4. Bottom sheet crash on multiple bottom sheet opening (Happens to be on IOS only)
  5. Devices are not removed from bottom sheet If not available any more (Fixed)
  6. DApp went to register Even It was register
  7. Dapp tries to sync even IF the device is not availble
  8. If the bottom sheet is open, Do not open another one

@reasje
Copy link
Author

reasje commented Mar 3, 2025

@SanghamitraBhowmick1993 Can you plz cehck This build which includes the fix for #5.
But I think the improvement can fix #3 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant