Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating projects Flutter version #106

Open
reasje opened this issue Nov 13, 2024 · 15 comments
Open

Updating projects Flutter version #106

reasje opened this issue Nov 13, 2024 · 15 comments
Assignees
Labels
bug Something isn't working

Comments

@reasje
Copy link

reasje commented Nov 13, 2024

We need to update the Flutter version in order to :

  1. Update packages and use new changes of packages
  2. Stay safe
@reasje reasje self-assigned this Nov 13, 2024
@reasje
Copy link
Author

reasje commented Nov 13, 2024

We will need to update the following :

  1. Flutter & Dart version : Gradle - Native dependencies ...
  2. Remote Packages compatible version
  3. Local package (Make PR to remote repo || Make our own repo)
  4. Update CI/CD and IOS 18 support

@reasje
Copy link
Author

reasje commented Nov 21, 2024

Dev log:
We have no big change from current Flutter version to the latest version that could break the project so I moved to latest right from here so Flutter version updated to 3.24.5.

@reasje
Copy link
Author

reasje commented Nov 21, 2024

Dev log:
Resolved initial dependency conflicts, I used method dependency override.
Reviewed and merged suggested syntax changes after the Flutter upgrade from VSCode.

@reasje
Copy link
Author

reasje commented Nov 21, 2024

Dev log:
Also fixed syntax issues on local auth package after disconnecting the use of dependency from local and changing It to remote.
Also fixed syntax issues on some of the UI components after the upgrade.

@reasje
Copy link
Author

reasje commented Nov 21, 2024

Dev log:
Some of dependency override have problems.
I fixed them by overriding a compatible version and also with removing the override and using compatible version in the required place.

@reasje
Copy link
Author

reasje commented Nov 21, 2024

Dev log:
Errors on dependency's dependency which are incompatible with the new Flutter version.
Fixed them by finding the dependency causing this error by looking at deps tree and upgrading to newer version.

@reasje
Copy link
Author

reasje commented Nov 25, 2024

Dev log:
Appinio pacakge upgrade started here.

@reasje
Copy link
Author

reasje commented Nov 28, 2024

@SanghamitraBhowmick1993
The first APK is out, Can you plz test end to end ?
Plz download apk form here.

Plz igonore features related to these functionalities because the package is going to change a lot.

  1. Background service
  2. Webview (with all features in inside It)

@reasje
Copy link
Author

reasje commented Nov 28, 2024

Dev log:
CI/CD updated, Changes include udpating the github actions for building for Android which included in logic change to include JDK 17.

@SanghamitraBhowmick1993
Copy link

SanghamitraBhowmick1993 commented Nov 29, 2024

Few observations:

  1. UI Overlay: There is a minor overlay affecting elements like the "Done" or "Confirm" button, causing visual interference.
    image
    image

  2. Token Balance Not Updating: After sending 40 MXC, the MXC token balance did not decrease as expected, indicating a possible synchronization issue.
    image

  3. Zero Amount Transfer Allowed: The system permits sending 0 MXC, which should not be allowed. Instead, it should either display an error message or disable the "Next" button when the transfer amount is invalid.
    image

  4. I don’t have WeChat, yet I still see the option in the export wallet.

Screenshot 2024-11-30 at 6 47 39 PM Screenshot 2024-11-30 at 6 47 49 PM
  1. Whatever I enter in the "From" field also appears in the "To" field and cannot be edited. These fields should be independently editable?
Screenshot 2024-11-30 at 6 49 19 PM

@reasje
Copy link
Author

reasje commented Dec 5, 2024

@SanghamitraBhowmick1993 Firebase changes are included on the latest release on pre main, It would be great If you can have a look on that too.

@reasje reasje added the bug Something isn't working label Dec 6, 2024
@reasje
Copy link
Author

reasje commented Dec 6, 2024

@SanghamitraBhowmick1993

  1. Working on It.
  2. Works for me, But doesn't work for you, Investigating....
  3. It's expected to have transaction with zero token or mxc sent, Can you plz ask for Sheen's opinion on this.
  4. Should be fixed on the next relase
  5. It's expected we just want to let the user know that the email's form and to is his/her email address, Which is a email to self to back up the phrase, If you have improvement proposal we would be glad to hear.

@SanghamitraBhowmick1993
Copy link

For #2, logs attached
Moonbase-log (2).txt

For #3, @sheenhx could you please help confirm if this is ok for now?
Zero Amount Transfer Allowed: The system permits sending 0 MXC, which should not be allowed. Instead, it should either display an error message or disable the "Next" button when the transfer amount is invalid.

image

@sheenhx
Copy link

sheenhx commented Dec 6, 2024

Should be allowed

@reasje
Copy link
Author

reasje commented Dec 11, 2024

@SanghamitraBhowmick1993 Can you plz check #1, All App's bottom sheets had the fix so It would be great If we can test them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants