-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Systemviewers fixes for older OpticStudio versions #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/v2.0.0/systemviewers # Conflicts: # tests/analyses/new/test_systemviewers.py # zospy/analyses/new/parsers/types.py
Similar as in #100, I think changelog can be skipped for this one? |
LucVV
added
the
skip changelog
It is not necessary to update the changelog for this PR
label
Dec 17, 2024
Yes, this is still part of the analysis conversion, which will be listed as a single item in the changelog. |
crnh
requested changes
Dec 17, 2024
crnh
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The new systemviewer implementation does not fully work with older versions of OpticStudio. There are two main issues:
AnalysisData
None
. In principlle this is oke, but it breaks the current json serialization. This is mainly a problem for some unit tests.assert result.AnalysisData is not None
, which fails for older OpticStudio versions due to point 1.Type of change
Additional information
Related issues
#97
Checklist
If you contributed an analysis:
AttrDict
s for the analysis result data (please use dataclasses instead).If you contributed an example: