Skip to content

Commit

Permalink
Fix start_surface assigment in physical_optics_propagation (#112)
Browse files Browse the repository at this point in the history
---------

Co-authored-by: PParant <papar129@ulaval.ca>
Co-authored-by: crnh <30109443+crnh@users.noreply.github.com>
  • Loading branch information
3 people authored Jan 16, 2025
1 parent b6f5beb commit a776c95
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ __pycache__/
# Editor settings
.idea/
.vscode/
.vs/

# Temporary data files
scripts/**/*.pickle
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ ZOS-API can also be added in patch releases.

### Removed

## [[1.3.1]](https://github.com/MREYE-LUMC/ZOSPy/releases/tag/v1.3.1) - 2025-01-16

### Fixed

- Physical optics analysis start surface was hardcoded to 1 (#111, #112)

## [[1.3.0]](https://github.com/MREYE-LUMC/ZOSPy/releases/tag/v1.3.0) - 2024-10-30

### Added
Expand Down
2 changes: 1 addition & 1 deletion zospy/analyses/physicaloptics.py
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ def physical_optics_propagation(
if start_surface == "Ent. Pupil":
analysis.Settings.StartSurface.SetSurfaceNumber(0)
elif isinstance(start_surface, int):
analysis.Settings.StartSurface.SetSurfaceNumber(1)
analysis.Settings.StartSurface.SetSurfaceNumber(start_surface)
else:
raise ValueError(f'start_surface value should be "Ent. Pupil" or an integer, got {start_surface}')

Expand Down

0 comments on commit a776c95

Please sign in to comment.