Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATS_PERCEL for GWE #2132

Closed
cneyens opened this issue Jan 9, 2025 · 4 comments
Closed

ATS_PERCEL for GWE #2132

cneyens opened this issue Jan 9, 2025 · 4 comments
Assignees

Comments

@cneyens
Copy link

cneyens commented Jan 9, 2025

Adaptive time-stepping based on a Courant number was introduced for GWT models in v6.6.0, which is a really nice feature. We've been doing some tests for energy transport of BHE's in advective systems and I was wondering if there are any plans to add the same capability to the ADV package of the GWE model?

@langevin-usgs langevin-usgs self-assigned this Jan 9, 2025
@langevin-usgs
Copy link
Contributor

Hi @cneyens, I think we can do this without too much trouble. I'll put it on the list. Stay tuned.

@emorway-usgs
Copy link
Contributor

emorway-usgs commented Jan 9, 2025

@langevin-usgs, @cneyens, both GWT and GWE use the same generalized transport ADV package. We haven't explicitly tested adaptive time-stepping in GWE, though it may already work by virtue of #1969?

@langevin-usgs
Copy link
Contributor

Good point, @emorway-usgs. It's probably close. At a minimum I think we need to update the GWE ADV definition file, and add a test.

@langevin-usgs
Copy link
Contributor

Close with #2133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants