Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation of "theta" CSUB observation type #1447

Closed
RichardWinston opened this issue Nov 16, 2023 · 1 comment · Fixed by #2137
Closed

Incorrect documentation of "theta" CSUB observation type #1447

RichardWinston opened this issue Nov 16, 2023 · 1 comment · Fixed by #2137
Assignees
Labels

Comments

@RichardWinston
Copy link

Describe the bug
In mf6io.pdf, the documentation of the "theta" observation type says its ID must be "icsubno" but in ex-gwf-csub-p04, a theta observation is included on line 47 in which the ID is "02_09_10" which is not an integer.

@langevin-usgs
Copy link
Contributor

It looks like the following bit of code allows for icsubno or boundname. @jdhughes-usgs, does the observation table need to be updated for theta and also for the delay-* observations so that that they can also be provided as boundname?

    ! -- get icsubno number or boundary name
    if (obsrv%ObsTypeId == 'CSUB' .or. &
        obsrv%ObsTypeId == 'INELASTIC-CSUB' .or. &
        obsrv%ObsTypeId == 'ELASTIC-CSUB' .or. &
        obsrv%ObsTypeId == 'SK' .or. &
        obsrv%ObsTypeId == 'SKE' .or. &
        obsrv%ObsTypeId == 'THETA' .or. &
        obsrv%ObsTypeId == 'THICKNESS' .or. &
        obsrv%ObsTypeId == 'INTERBED-COMPACTION' .or. &
        obsrv%ObsTypeId == 'INELASTIC-COMPACTION' .or. &
        obsrv%ObsTypeId == 'ELASTIC-COMPACTION' .or. &
        obsrv%ObsTypeId == 'DELAY-HEAD' .or. &
        obsrv%ObsTypeId == 'DELAY-GSTRESS' .or. &
        obsrv%ObsTypeId == 'DELAY-ESTRESS' .or. &
        obsrv%ObsTypeId == 'DELAY-PRECONSTRESS' .or. &
        obsrv%ObsTypeId == 'DELAY-COMPACTION' .or. &
        obsrv%ObsTypeId == 'DELAY-THICKNESS' .or. &
        obsrv%ObsTypeId == 'DELAY-THETA' .or. &
        obsrv%ObsTypeId == 'DELAY-FLOWTOP' .or. &
        obsrv%ObsTypeId == 'DELAY-FLOWBOT') then
      call extract_idnum_or_bndname(string, icol, istart, istop, nn1, bndname)

jdhughes-usgs added a commit to jdhughes-usgs/modflow6 that referenced this issue Dec 17, 2024
Make mf6io and code consistent.

Closes MODFLOW-USGS#1447
jdhughes-usgs added a commit to MODFLOW-USGS/modflow6-examples that referenced this issue Dec 19, 2024
Remove boundname from csub theta observations.

Addresses MODFLOW-USGS/modflow6#1447
wpbonelli pushed a commit to MODFLOW-USGS/modflow6-examples that referenced this issue Dec 19, 2024
Remove boundname from csub theta observations.

Addresses MODFLOW-USGS/modflow6#1447
jdhughes-usgs added a commit to jdhughes-usgs/modflow6 that referenced this issue Dec 19, 2024
Make mf6io and code consistent.

Closes MODFLOW-USGS#1447
jdhughes-usgs added a commit to jdhughes-usgs/modflow6 that referenced this issue Dec 20, 2024
Make mf6io and code consistent.

Closes MODFLOW-USGS#1447
jdhughes-usgs added a commit to jdhughes-usgs/modflow6 that referenced this issue Jan 10, 2025
Make mf6io and code consistent.

Closes MODFLOW-USGS#1447
jdhughes-usgs added a commit that referenced this issue Jan 15, 2025
* Make mf6io and code consistent.
* Add observation test.

Closes #1447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants